Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): add key modifiers to pointer event args #18929

Merged

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes https://github.com/unoplatform/uno.hotdesign/issues/3010

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@ramezgerges
Copy link
Contributor Author

For QA: the ListView_Selection_Pointers sample in SamplesApp shows ListViews in different selection modes. To validate this PR, you only need to look at the ListViews marked "single selection", "multiple selection", and "extended selection". These different selection modes work with Shift and Ctrl to be able to select a number of items at the same time. Try various combinations and compare with WinUI.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18929/index.html

Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18929/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148525 has failed on Uno.UI - CI.

@jeromelaban jeromelaban disabled auto-merge November 27, 2024 13:26
@jeromelaban jeromelaban merged commit f2f4743 into unoplatform:master Nov 27, 2024
112 of 114 checks passed
@ramezgerges ramezgerges deleted the macos_pointer_events_mods branch November 27, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants