Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust support for InvariantCulture mode support #18934

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: Adjust support for InvariantCulture mode support #18934

merged 1 commit into from
Nov 27, 2024
+65 −9

Conversation

jeromelaban
Copy link
Member

GitHub Issue (If applicable): closes #18283

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

Fixes the support for InvariantCulture mode.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Nov 26, 2024
@jeromelaban jeromelaban force-pushed the dev/jela/invariant-support branch from 7dc1462 to 39931e8 Compare November 26, 2024 21:42
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18934/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18934/index.html

@nventive-devops
Copy link
Contributor

The build 148561 found UI Test snapshots differences: android-28-net8: 31, android-28-net8-Snap: 48, ios: 6, ios-Snap: 46, skia-gtk-screenshots: 61, skia-linux-screenshots: 65, skia-windows-screenshots: 72, wasm: 485, wasm-automated-net9.0-UWP-Default-automated: 26, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net8: 31 changed over 829

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Button_NestedButtons_Validation_nVentive_Umbrella_Views_UI_Samples_Content_UITests_ButtonTestsControl_Nested_Buttons
    • CheckBox_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated
    • DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • Detereminate_ProgressRing_Validation0_[#FF0000_#FF0000_#FF0000_#FF0000]_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing
    • Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
    • Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
    • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
    • FlyoutTest_Target_Uno_UI_Samples_Content_UITests_Flyout_Flyout_Target
    • Ellipse_Page_SamplesApp_Windows_UI_Xaml_Shapes_EllipsePage
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • NavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
    • SelectionOnLoad_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsInitialLoadSelected
    • TextBox_CharacterCasingNormal_ShouldAcceptAllCasing_Test_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_CharacterCasing
    • UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • ValidateResourceLoader_Simple_UITests_Shared_Windows_ApplicationModel_Resources_ResourceLoader_ResourceLoader_Simple
    • WebView_NavigateToAnchor_Initial
    • When_Hardware_Back_Button_Pressed_UITests_Windows_UI_Core_SystemNavigationManagerTests_HardwareBackButton

  • android-28-net8-Snap: 48 changed over 1068

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
    • Brushes_UITests_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_Formats_UITests_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_Formats
    • TextBlock_TextBlock_Hyperlink_Touch_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Hyperlink_Touch
    • TextBlock_TextBlock_Hyperlink_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Hyperlink
    • TextBlock_TextBlock_Inlines_TemplatedParent_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Inlines_TemplatedParent
    • Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • TextBlock_TextBlock_LineHeight_Multiline_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_Multiline
    • Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
    • NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • TextBox_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxControl_TextBox_Binding_Null_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxControl_TextBox_Binding_Null
    • TextBox_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_Width_Affects_Delete_Button_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_Width_Affects_Delete_Button
    • TextBox_UITests_Windows_UI_Xaml_Controls_PasswordBoxTests_PasswordBox_AutoFill_UITests_Windows_UI_Xaml_Controls_PasswordBoxTests_PasswordBox_AutoFill
    • TextBox_UITests_Windows_UI_Xaml_Controls_PasswordBoxTests_PasswordBox_iOS_DuplicatingText_UITests_Windows_UI_Xaml_Controls_PasswordBoxTests_PasswordBox_iOS_DuplicatingText
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • Shapes_SamplesApp_Windows_UI_Xaml_Shapes_EllipsePage_SamplesApp_Windows_UI_Xaml_Shapes_EllipsePage
    • Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics

  • ios: 6 changed over 267

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220

  • ios-Snap: 46 changed over 1059

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable
    • Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
    • Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground
    • ListView_ListViewHeaderFooter_ImplicitlyBinded_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderFooter_ImplicitlyBinded
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
    • WebView_WebView2_WithHeaders_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_WithHeaders
    • Buttons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • NavigationView_NavigationViewSample_SamplesApp_Samples_NavigationViewSample_NavigationViewSample
    • ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider
    • NavigationView_MUXControlsTestApp_NavigationViewMinimalPage_MUXControlsTestApp_NavigationViewMinimalPage
    • NavigationView_MUXControlsTestApp_NavigationViewRS3Page_MUXControlsTestApp_NavigationViewRS3Page
    • ContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
    • NavigationView_MUXControlsTestApp_NavigationViewMenuItemStretchPage_MUXControlsTestApp_NavigationViewMenuItemStretchPage
    • WebView_WebView_WithHeaders_Uno_UI_Samples_Content_UITests_WebView_WebView_WithHeaders

  • skia-gtk-screenshots: 61 changed over 2234

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RepeatButton_Automated.png-dark
    • RepeatButton_Automated.png
    • UIElement_MeasureDirtyPath.png-dark
    • UIElement_MeasureDirtyPath.png
    • WinUIExpanderPage.png
    • WinUIProgressBarSimple.png-dark
    • WinUIProgressBarSimple.png
    • Gamepad_Enumeration.png
    • Buttons.png-dark
    • Buttons.png
    • CalendarView_Theming.png-dark
    • CalendarView_Theming.png
    • Gamepad_Enumeration.png-dark
    • NetworkInformation.png-dark
    • Focus_FocusVisual_Properties.png
    • Ellipse.png-dark
    • Ellipse.png
    • Examples.png
    • ImagesInlineInFlipView.png-dark
    • ImagesInlineInFlipView.png

  • skia-linux-screenshots: 65 changed over 2234

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • CalendarView_Theming.png
    • ClipboardTests.png-dark
    • Gamepad_Enumeration.png-dark
    • Gamepad_Enumeration.png
    • BorderImageBrush.png-dark
    • CalendarView_Theming.png-dark
    • ClipboardTests.png
    • DropDownButtonPage.png-dark
    • DropDownButtonPage.png
    • Ellipse.png-dark
    • Ellipse.png
    • Focus_FocusVisual_Properties.png-dark
    • Focus_FocusVisual_Properties.png
    • ImageBrushInList.png-dark
    • ImageBrushInList.png
    • BorderImageBrush.png
    • DisplayInformation.png-dark
    • DisplayInformation.png
    • ImageInStackPanel.png-dark
    • ImageInStackPanel.png

  • skia-windows-screenshots: 72 changed over 2234

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AppWindowPositionAndSize.png-dark
    • Examples.png
    • Buttons.png
    • ContentPresenter_NativeEmbedding.png-dark
    • ContentPresenter_NativeEmbedding.png
    • BorderImageBrushRelativeTransform.png
    • DropDownButtonPage.png-dark
    • DropDownButtonPage.png
    • Gamepad_Enumeration.png-dark
    • Gamepad_Enumeration.png
    • ImageBrushInList.png-dark
    • ImageBrushInList.png
    • AppWindowPositionAndSize.png
    • ImageInStackPanel.png-dark
    • ImageInStackPanel.png
    • ImagesInlineInFlipView.png-dark
    • ImagesInlineInFlipView.png
    • CalendarView_Theming.png-dark
    • CalendarView_Theming.png
    • ClipboardTests.png

  • wasm: 485 changed over 1045

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Picker
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.Picker_Resizable
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderImage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
    • SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.FixedWidth
    • UITests.Microsoft_UI_Xaml_Controls.RefreshContainerTests.RefreshContainerHorizontalScroll
    • UITests.Shared.Windows_UI_Input.GestureRecognizerTests.RightTappedTests
    • UITests.Shared.Windows_UI_Input.GestureRecognizerTests.TappedTest
    • UITests.Shared.Windows_UI_Xaml_Controls.Flyout.Flyout_Unloaded
    • UITests.Shared.Windows_UI_Xaml_Controls.ViewBoxTests.ViewBox_Alignment
    • UITests.Windows_Devices.Haptics.VibrationDeviceTests
    • UITests.Windows_Devices.Midi.MidiDeviceInput
    • UITests.Windows_Devices.Power.Battery
    • UITests.Windows_Gaming.GamepadEnumerationTest
    • UITests.Windows_UI_Xaml.FocusTests.Focus_VisualStates
    • UITests.Windows_UI_Xaml.FrameworkElementTests.DynamicBackgroundSizing
    • UITests.Windows_UI_Xaml.FrameworkElementTests.FrameworkElement_Opacity
    • UITests.Windows_UI_Xaml_Controls.Canvas.Grid_ZIndex
    • UITests.Windows_UI_Xaml_Controls.CheckBoxTests.CheckBox_States
    • UITests.Windows_UI_Xaml_Controls.ListView.ListViewTemplateRootIsContainer

  • wasm-automated-net9.0-UWP-Default-automated: 26 changed over 1948

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
    • ListView_ListViewHeaderImage_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderImage
    • Default_StrokeThickness_MyRect
    • Default_StrokeThickness_MyRect_0_StrokeThickness
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Default_StrokeThickness_MyPolygon
    • Default_StrokeThickness_MyPolygon_0_StrokeThickness
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
    • Default_StrokeThickness_MyPath
    • Default_StrokeThickness_MyEllipse_0_StrokeThickness
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage

  • wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

@jeromelaban jeromelaban marked this pull request as ready for review November 27, 2024 12:32
@jeromelaban jeromelaban merged commit f75fc1d into master Nov 27, 2024
115 checks passed
@jeromelaban jeromelaban deleted the dev/jela/invariant-support branch November 27, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@MartinZikmund MartinZikmund Awaiting requested review from MartinZikmund

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

Assignees
No one assigned
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for InvariantCulture mode
4 participants
@jeromelaban @unodevops @nventive-devops @spouliot