Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounting hook breaks after adding 2nd hook #1

Open
kreczko opened this issue Jul 5, 2019 · 1 comment
Open

Accounting hook breaks after adding 2nd hook #1

kreczko opened this issue Jul 5, 2019 · 1 comment

Comments

@kreczko
Copy link
Member

kreczko commented Jul 5, 2019

@simonecid here is the ticket

Last working version is 8f4b497.
Which provides these lines in the log file (/var/log/condor/JobRouterLog):

07/05/19 13:02:54 JobRouter (src=4151.0,route=Add accounting information to jobs): Done editing job.

Somewhere between a774652 and e5bbed2 the code breaks:

  • a774652: htcondor_hooks/accounting_hook.py → hooks/accounting.py
  • 5ed2275: replaced functions in hooks/accounting.py with htcondor_hooks.core.*
  • 83e8c6b: added blacklist
  • 58632ed: insert htcondor_hooks path to sys.path
  • deb5fc4: removal of logger from htcondor_hooks.core.*
  • 2707999, 6b8c260 & e5bbed2: fixes for blacklist

Error message:

07/05/19 11:26:57 TranslateClient::hookExited (src=7388.0,route=Blacklist certain machines for local users): Failed to insert "EnteredCurrentSt" into ClassAd, ignoring invalid hook output
07/05/19 11:26:57 TranslateClient::hookExited (src=7396.0,route=Blacklist certain machines for local users): Failed to insert "EnteredCurrent" into ClassAd, ignoring invalid hook output
07/05/19 11:26:57 TranslateClient::hookExited (src=4158.0,route=Blacklist certain machines for local users): Failed to insert "C" into ClassAd, ignoring invalid hook output

First I am going to replay all the code changes and check with

service condor restart

(condor_reconfig does not try to re-apply the hooks --> no messages)

@kreczko
Copy link
Member Author

kreczko commented Aug 12, 2019

From @EmyrClement: "Machine requirements need to be in quotes"

The current implementation, https://github.com/uobdic/htcondor-hooks/blob/master/hooks/blacklist.py#L36, relies on the JobAds to parse things correctly, but that does not happen for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant