Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate best way to functionally test the app #94

Open
danillouz opened this issue Dec 8, 2019 · 0 comments
Open

Investigate best way to functionally test the app #94

danillouz opened this issue Dec 8, 2019 · 0 comments
Assignees
@danillouz
Labels
question Further information is requested

Comments

@danillouz
Copy link
Member

Currently there are no integration/functional tests for the app. The main reason is that it's not possible to to mock/stub the Auth0 auth flow that uses PKCE (nor should we want to!).

But I think it would still be very useful to test (parts) of the app using cypress.

A possible approach to achieve this could be to render a "custom" app (using the same components) but without any auth. But only if this adds value and confidence.
@danillouz danillouz added the question Further information is requested label Dec 8, 2019
@danillouz danillouz self-assigned this Dec 8, 2019
danillouz pushed a commit that referenced this issue Dec 8, 2019
Disable e2e testing
9caf061 
There was one test for the failed login flow, but it only worked because
of a bug (that was fixed in #91).

I think it's better to take a step back, and rethink the best way
to e2e test the app (because of the implications of the app's auth flow
using PKCE).

Therefore I'm temporarily disabling e2e in the CI/CD pipeline, and deleting the
"login failed" e2e test. This test will be converted to a component unit test
instead.

For more information see:
#94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danillouz danillouz

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danillouz