-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit duplicate wf error in first invocation & not found in cleanup #16
Conversation
this won't be merged right away. We will get a canary release from this branch to verify the solution. If all looks good, we will merge to main. |
we should update client.trigger in this PR too #18 |
previously, the backend returned an error when we tried to create a workflow with the same id. Now, they return success with deduplication: true.
b5c0212
to
51b71eb
Compare
can't pass the tests because they are too flaky. we had passed the tests in 51b71eb, and after that change we only bumped qstash and updated how we check omit error cases. The unit tests pass. I ran the integration test which fails locally and it works. We can go ahead without the CI. |
There are cases where network errors cause workflow runs to fail.
This PR handles three of those cases:
In both cases, the debugger will log warnings.