Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rust builds of Fish shell #7

Open
Matthew-Benson opened this issue May 7, 2024 · 1 comment
Open

Support Rust builds of Fish shell #7

Matthew-Benson opened this issue May 7, 2024 · 1 comment

Comments

@Matthew-Benson
Copy link
Collaborator

Starting with Fish 3.8.0, the official release of Fish shell is built with Rust primarily. With 3.8.0 not having released at the time of writing this, the build/install process for this has not been finalized and work is currently ongoing in fish-shell/fish-shell#10367.

We will need to use the rust toolchain from rules_rust to build this. It should be relatively simple, as I believe Fish is planning to just build the binary with cargo build, but they intend to maintain cmake to some extend for installation. This may change though since this is all up-in-the-air.

If we need, we may be able to generate a native build dynamically using Gazelle with gazelle_rust to make build targets based on project imports, etc.

@faho
Copy link

faho commented May 14, 2024

the build/install process for this has not been finalized and work is currently ongoing in fish-shell/fish-shell#10367.

Note: That PR is for a separate option to build/install fish.

We have no plans or inclination to drop the regular build or promote this one to be the main thing. It has some awkward downsides.

You want to follow fish-shell/fish-shell#10181 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants