Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ful14 security patches #48

Open
wants to merge 12 commits into
base: ful14
Choose a base branch
from
Open

Ful14 security patches #48

wants to merge 12 commits into from

Conversation

bcbrakelOSI
Copy link

Description of the issue/feature this PR addresses:
This PR applies all of the security patches that were announced for Odoo in December 2021 except for one which may potentially break large object support, or cause other issues. This last patch will be concluded as soon as we have a response from Odoo clarifying what the patch does.

Current behavior before PR:
Security patches have not been applied.

Desired behavior after PR is merged:
Security patches have been applied with no adverse alterations to Odoo's functionality.

mart-e and others added 12 commits February 18, 2022 09:16
Fix of 57665a0 which was problematic in point_of_sale
Partially backport the changes from 49429f9 to file_open to be
able to use it in the assetsbundle
Only admin users should be able to load demo data, if needed.

This is only possible from the settings dashboard, and thus,
the method could be decorated.

See: c002e2e
This is internal data that does not need to be shown to the user
Using an explicit list of sign up parameters will avoid
polluting the context with unrelated values, and make
debugging easier.
5195550 mitigated an issue of being
able to try and download files which don't exist yet, make the fix
more reliable by clearing out the field completely and hiding the
content if the (readonly) field has no value *or the record is not
saved yet*.

Also clean up the code:

* an old-style forward port created a duplicate fixprovement
  (a8d01cb) which seems less correct
  as it applies conditionally
* and the code is branchier than necessary, we can make it simpler by
  judiciously leveraging jquery's API

closes odoo#77756

X-original-commit: 05db9be
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Copy link

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

10 participants