forked from fastluca/JRis
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Gracefulness of RIS Import #134
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Based on suggestions provided by @adamsmd in issue #129, I'd like to improve the way KRis handles the import.
While the apparent issue of unexpected types of the RIS Tag
M1
(containing ranges or otherwise non-numeric content) was already worked around in PR #133 by changing the Type of the property associated with TagM1
fromLong?
toString?
, the user experience of importing from RIS files is not very good. (Side note: This is most likely the case due to the fact that I only use KRis for exporting, not for importing. Hence the import is less polished by the lack of "dog-fooding").As a general direction, KRis should not only keep track of the type safe value of the tag content, but also of the raw value. There may be other types that may contain content not complying with KRis' assumption of the data type. In case the type conversion fails, the user of KRis should be
The text was updated successfully, but these errors were encountered: