Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Sans - Feature: [add support for pinyin with tones] #258

Open
2 tasks done
vivvienne opened this issue Jul 12, 2022 · 0 comments
Open
2 tasks done

Public Sans - Feature: [add support for pinyin with tones] #258

vivvienne opened this issue Jul 12, 2022 · 0 comments
Labels
Type: Feature Request New functionality

Comments

@vivvienne
Copy link

vivvienne commented Jul 12, 2022

Is your feature request related to a problem? Please describe.

Hi.

While I was using the font with some text including pinyin with tones, I noticed some characters are not currently supported. So I did a simple check with a table for letters used in pinyin at Wikipedia, and found that these single codepoint characters seem to be absent in Public Sans.

  • Ǎ, Ǐ, Ǒ, Ǔ, ǎ, ǐ, ǒ
  • Ǖ, Ǘ, Ǚ, Ǜ, ǖ, ǘ, ǚ, ǜ
  • (rare letters) Ḿ, Ǹ, ḿ, ǹ

While the ones in the 1st and 3rd rows (with only 1 diacritic) can still be expressed with the base letter and a combining diacritic (such as a combining caron U+030C), the ones in the second row (with a diaeresis and another diacritic) cannot be done so because the positions of combining diacritics clash with one another.

Other rarer combinations also suffer from the diacritic clashing problem: Ê̄, Ê̌, ê̄, ê̌.

And other combinations seem for some reason to not combine at all: M̄, M̌, M̀, m̄, m̌, m̀.

Describe the solution you'd like

It would be great if

  • Single codepoint characters exist in the font as precomposed characters
  • Composed characters using combining diacritics do combine without clashing

Describe alternatives you've considered

No response

Additional context

No response

Code of Conduct

@vivvienne vivvienne added Status: Triage We're triaging this issue and grooming if necessary Type: Feature Request New functionality labels Jul 12, 2022
@mejiaj mejiaj removed the Status: Triage We're triaging this issue and grooming if necessary label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request New functionality
Projects
Status: TBD
Development

No branches or pull requests

3 participants