Implement Tag Store Validations Through Existing TagUpdateRequest

app/Http/Controllers/TagsController.php

@@ -73,9 +73,9 @@ public function create(): View|ViewContract
     /**
      * Save the tag in the database.
      */
-    public function store(Request $request): RedirectResponse
+    public function store(TagUpdateRequest $request): RedirectResponse
     {
-        Tag::findOrCreate(preg_split('/\r\n|\r|\n/', $request->tag_name ?? ''), $request->tag_type);
+        Tag::findOrCreate(preg_split('/\r\n|\r|\n/', $request->name ?? ''), $request->type);
 
         return redirect()->route('tags.table')
             ->with('flash_message', 'Added tags');

app/Http/Requests/TagUpdateRequest.php

@@ -2,11 +2,15 @@
 
 namespace App\Http\Requests;
 
+use App\Rules\EachIsUnique;
+use App\Student;
 use Illuminate\Foundation\Http\FormRequest;
 use Illuminate\Validation\Rule;
 
 class TagUpdateRequest extends FormRequest
 {
+    public $tag_types = [];
+
     /**
      * Determine if the user is authorized to make this request.
      *
@@ -24,27 +28,35 @@ public function authorize()
      */
     public function rules()
     {
+        $this->tag_types[] = "App\\Profile";
         $locale = app()->getLocale();
+
+        foreach (Student::participatingSchools() as $shortname => $name) {
+            $this->tag_types[]= "App\\Student\\{$shortname}";
+        }
 
         return [
-           'type' => 'required',
-           'name' => [
+            'type' => [
+                        'required',
+                        'string',
+                        Rule::in($this->tag_types),
+                    ],
+            'name' => [
                         'required',
                         'string',
                         'max:100',
-                        Rule::unique('tags', 'name->'.$locale)
-                                ->where('type', $this->input('type'))
-                                ->ignore($this->input('id'))
+                        (new EachIsUnique('/\r\n|\r|\n/', 'tags', 'name->'.$locale, ['type', $this->input('type')]))
+                            ->ignore($this->route()->parameters['tag'] ?? null),
                     ],
         ];
     }
 
     public function messages()
     {
+        $types_allowed = implode(', ', $this->tag_types);
+
         return [
-            'name.required' => 'The tag name is required.',
-            'name.unique' => 'The tag name provided already exists.',
-            'name.max' => 'The tag name provided exceeds maximum length of 100 characters.',
+            'type.in' => "The tag types allowed are: {$types_allowed}",
         ]; 
     }
 

app/Rules/EachIsUnique.php

@@ -0,0 +1,83 @@
+<?php
+
+namespace App\Rules;
+
+use Closure;
+use Illuminate\Contracts\Validation\ValidationRule;
+use Illuminate\Validation\Rule;
+use Illuminate\Support\Str;
+
+class EachIsUnique implements ValidationRule
+{
+    protected string $delimiter;
+    protected string $table;
+    protected string $column;
+    protected array $constraint;
+    protected $ignore_id;
+    protected $ignore_column;
+
+    /**
+     * Create a new validation rule instance.
+     *
+     * @param string $delimiter   Delimiter to split the field under validation into individual elements.
+     * @param string $table       Table where the uniqueness check will be performed.
+     * @param string $column      Column in the table where uniqueness will be checked.
+     * @param array  $constraint  Constraint for the where method to apply when checking uniqueness in the format of ['column', 'value'].
+     */
+    public function __construct($delimiter, $table, $column, $constraint = null)
+    {
+        $this->delimiter = $delimiter;
+        $this->table = $table;
+        $this->column = $column;
+        $this->constraint = $constraint;
+    }
+
+    /**
+     * Run the validation rule.
+     *
+     * @param  \Closure(string): \Illuminate\Translation\PotentiallyTranslatedString  $fail
+     */
+    public function validate(string $attribute, mixed $value, Closure $fail): void
+    {
+        $values = $errors = [];
+
+        $values = is_string($value) ? preg_split($this->delimiter, $value) : [];
+
+        $rule = Rule::unique($this->table, $this->column);
+
+        if (isset($this->constraint)) {
+            $rule->where($this->constraint[0], $this->constraint[1]); 
+        }
+
+        if (isset($this->ignore_id)) {
+            $rule->ignore($this->ignore_id, $this->ignore_column);
+        }
+
+        foreach ($values as $value) {
+            $valid = !validator([$attribute => $value], [$attribute => $rule])->fails();
+
+            if (!$valid) {
+                $errors[] = "The {$value} tag already exists for the {$this->constraint[1]} {$this->constraint[0]}.";
+            }
+        }
+
+        foreach ($errors as $error) {
+            $fail($error);
+        }
+    }
+
+    /**
+     * Set values to be excluded or ignored by the unique checks.
+     * 
+     * @param mixed $id - the ID or model instance of the record to ignore
+     * @param string|null $id_column - The column name of the primary key, if it's other than the ID
+     */
+    public function ignore($id, $idColumn = null)
+    {
+        $this->ignore_id = $id;
+        $this->ignore_column = $idColumn;
+
+        return $this;
+    }
+
+}

resources/views/tags/create.blade.php

@@ -22,17 +22,18 @@
 <div class="container">
     <h1><i class="fas fa-tags" aria-hidden="true"></i> Add Tags</h1>
 
+    @include('errors/list')
     {!! Form::open(['route' => 'tags.store']) !!}
 
     <div class="mb-3">
-        {!! Form::label('tag_name', 'Tag name(s)', ['class' => 'form-label']) !!}
+        {!! Form::label('name', 'Tag name(s)', ['class' => 'form-label']) !!}
         <small class="text-muted">One tag per line</small>
-        {!! Form::textarea('tag_name', null, ['class' => 'form-control', 'required']) !!}
+        {!! Form::textarea('name', null, ['class' => 'form-control', 'required']) !!}
     </div>
     <div class="mb-3">
-        {!! Form::label('tag_type', 'Tag type', ['class' => 'form-label']) !!}
+        {!! Form::label('type', 'Tag type', ['class' => 'form-label']) !!}
         <small class="text-muted">e.g. App\Profile, App\Student, and etc.</small>
-        {!! Form::text('tag_type', null, ['class' => 'form-control', 'required']) !!}
+        {!! Form::text('type', null, ['class' => 'form-control', 'required']) !!}
     </div>
 
     <button type="submit" class="btn btn-primary edit-button">Submit</button>

resources/views/tags/edit.blade.php

@@ -22,7 +22,7 @@
 <div class="container">
     <h1><i class="fas fa-tags" aria-hidden="true"></i> Edit Tag {{ $tag->name }}</h1>
 
-    @include('errors/has')
+    @include('errors/list')
 
     {!! Form::model($tag, ['method' => 'PATCH','route' => ['tags.updateTag', $tag], 'class' => 'form-horizontal' ]) !!}