Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oneMKL] dft::descriptor copy and move (#487) #490

Merged
merged 3 commits into from
Jul 21, 2023
Merged

[oneMKL] dft::descriptor copy and move (#487) #490

merged 3 commits into from
Jul 21, 2023

Conversation

hjabird
Copy link
Contributor

@hjabird hjabird commented Jul 7, 2023

@hjabird
[oneMKL] dft::descriptor copy and move (uxlfoundation#487)
ba373d7 
* Relates to uxlfoundation#487
* Adds move constructor/assignment to descriptor class
  * Otherwise implicitly deleted.
* Add explicit copy constructor/assignment to descriptor class
  * Otherwise ambigiuous
* Notes that copy operation is by value.
@hjabird hjabird mentioned this pull request Jul 10, 2023
Merged
@hjabird @FMarno
Reword (Suggestion FMarno)
656553a 
Co-authored-by: Finlay <finlay.marno@codeplay.com>
@hjabird
Copy link
Contributor Author

hjabird commented Jul 13, 2023

Pinging @lhuot @anantsrivastava30 .

@mmeterel mmeterel merged commit 2a1f109 into uxlfoundation:main Jul 21, 2023
3 checks passed
@hjabird hjabird mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FMarno FMarno FMarno approved these changes

@anantsrivastava30 anantsrivastava30 anantsrivastava30 approved these changes

@Rbiessy Rbiessy Rbiessy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hjabird @FMarno @anantsrivastava30 @Rbiessy @mmeterel