[oneDPL][RNG][Spec] Added the extensions sections #492
Conversation
| alternative requirements apply: for an engine object ``g`` of type ``G``, | ||
|
|
||
| - ``G::scalar_type`` is an unsigned integral type same as ``sycl::vec<Type,N>::element_type``, |
There was a problem hiding this comment.
| alternative requirements apply: for an engine object ``g`` of type ``G``, | |
| - ``G::scalar_type`` is an unsigned integral type same as ``sycl::vec<Type,N>::element_type``, | |
| alternative requirements apply. | |
| For an engine object ``g`` of type ``G``: | |
| - ``G::scalar_type`` is an unsigned integral type same as ``sycl::vec<Type,N>::element_type``, |
There was a problem hiding this comment.
I am afraid, in this way it's not quite clear what the alternative requirements are. Let's try improving it later.
There was a problem hiding this comment.
Postpone the change
| - ``operator()`` of a distribution returns a ``sycl::vec<Type,N>`` filled with random values | ||
| in the closed interval ``[D::min(), D::max()]``; | ||
|
|
||
| The following engines and engine adaptors with predefined parameters are defined: |
There was a problem hiding this comment.
| The following engines and engine adaptors with predefined parameters are defined: | |
| The following template aliases for engines and engine adaptors are defined: |
There was a problem hiding this comment.
The wording "with predefined parameters" is aligned with C++ std. Should we change it?
There was a problem hiding this comment.
No, I think we should keep it. From the RNG standpoint, it's exactly engines with predefined parameters.
There was a problem hiding this comment.
Kept it as it is now
There was a problem hiding this comment.
I disagree, because in the standard they don't have template aliases to the best of my knowledge. But I don't want to argue.
There was a problem hiding this comment.
https://eel.is/c++draft/rand.predef
using minstd_rand0 =
linear_congruential_engine<uint_fast32_t, 16'807, 0, 2'147'483'647>;
and so on. OK, not template, just aliases.
* [oneDPL][RNG][Spec] Added the extensions sections * Applying the comments * Applying changes from Alexey * Fixing the lines lengthexey * Fix of the line * Applying the comments from Ruslan
The "extensions section" with description of main differences between C++ std. RNG and oneDPL std. RNG has been added to oneAPI specification