[oneMKL][Sparse BLAS] Add sycl::queue & to sparse::init_matrix_handle() API
#505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerpatty
approved these changes
Oct 3, 2023
|
Looks good to me, thanks! |
6 tasks
|
@spencerpatty, please merge this PR in when you get a chance. |
|
@rscohn2, could you please confirm that if this PR is merged in right now, it will be made part of the oneAPI specification version 1.3 that will be created/released soon? |
Yes |
aepanchi
pushed a commit
to aepanchi/oneAPI-spec
that referenced
this pull request
Oct 31, 2023
gajanan-choudhary
deleted the
oneMKL/SpBLAS/gajanan-choudhary/add-queue-to-init_matrix_handle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
oneapi::mkl::sparse::init_matrix_handle()API to also include asycl::queue &queueas a function argument.queueis part of the API forqueuein there, implementations need to maintain an implementation ofoneapi::mkl::sparse::matrix_handle_t.queuein there, implementations can directly forward the arguments to different backend implementations such as the Intel oneMKL library or the cuSPARSE library.release_matrix_handle()documentation that was missed out; just a minor typo.