Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system libraries for dependencies #3

Open
zflat opened this issue Dec 13, 2022 · 1 comment
Open

Use system libraries for dependencies #3

zflat opened this issue Dec 13, 2022 · 1 comment

Comments

@zflat
Copy link

zflat commented Dec 13, 2022

Right now, RWS is using websocketpp, asio and nlohmann/json and these 3 libraries will be fetched by CMake during configuration step. Is there a reason they need to be built like this? Can the libraries installable via apt work?

You can add the following to the package.xml file

<build_depend>asio</build_depend>
<build_depend>nlohmann-json-dev</build_depend>
<build_depend>libwebsocketpp-dev</build_depend>

Then the rosdep tool can be used to install the correct packages from apt. Note that the rosdep tool works for other linux distributions than just Ubuntu.

Maybe you can also change the CMakeLists.txt to attempt to find_package and if it fails to find a package then fetch and build? I also think that automatic fetching and building should be an option that is disabled by default.

@v-kiniv
Copy link
Owner

v-kiniv commented Dec 18, 2022

rosdep is not working on Mac, also asio and websocketpp are a bit outdated on Ubuntu 20.04, that was the reasons, but I agree that automatic fetching should be optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants