From d14720b279b062638be0e15b6f927528cd57a86e Mon Sep 17 00:00:00 2001 From: Tomi Virkki Date: Thu, 3 Oct 2024 19:56:01 +0300 Subject: [PATCH] fix firefox dragging issue --- packages/dashboard/src/vaadin-dashboard-section.js | 4 +++- packages/dashboard/src/vaadin-dashboard-widget.js | 4 +++- .../dashboard/theme/lumo/vaadin-dashboard-widget-styles.js | 5 ++++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/packages/dashboard/src/vaadin-dashboard-section.js b/packages/dashboard/src/vaadin-dashboard-section.js index 11c1a1cfe8..b880b8b16a 100644 --- a/packages/dashboard/src/vaadin-dashboard-section.js +++ b/packages/dashboard/src/vaadin-dashboard-section.js @@ -204,7 +204,9 @@ class DashboardSection extends DashboardItemMixin( /** @protected */ ready() { super.ready(); - this.role ??= 'section'; + if (!this.role) { + this.role = 'section'; + } } } diff --git a/packages/dashboard/src/vaadin-dashboard-widget.js b/packages/dashboard/src/vaadin-dashboard-widget.js index bf699e6845..3aef679786 100644 --- a/packages/dashboard/src/vaadin-dashboard-widget.js +++ b/packages/dashboard/src/vaadin-dashboard-widget.js @@ -254,7 +254,9 @@ class DashboardWidget extends DashboardItemMixin( /** @protected */ ready() { super.ready(); - this.role ??= 'article'; + if (!this.role) { + this.role = 'article'; + } } /** @private */ diff --git a/packages/dashboard/theme/lumo/vaadin-dashboard-widget-styles.js b/packages/dashboard/theme/lumo/vaadin-dashboard-widget-styles.js index db3a75eaa4..0edb466b16 100644 --- a/packages/dashboard/theme/lumo/vaadin-dashboard-widget-styles.js +++ b/packages/dashboard/theme/lumo/vaadin-dashboard-widget-styles.js @@ -27,7 +27,7 @@ const dashboardWidgetAndSection = css` outline: none; } - :host([focused])::before { + :host::before { content: ''; display: block; position: absolute; @@ -35,6 +35,9 @@ const dashboardWidgetAndSection = css` border-radius: var(--lumo-border-radius-l); pointer-events: none; margin: calc(var(--_focus-ring-spacing-offset) * -1); + } + + :host([focused])::before { outline: var(--_focus-ring-width) solid var(--_focus-ring-color); }