Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--vaadin-input-field-hover-highlight is not applied to vaadin-text-area #7423

Open
MarcinVaadin opened this issue May 17, 2024 · 1 comment
Labels
DX Developer experience issue requires new major This would be a breaking change vaadin-text-area

Comments

@MarcinVaadin
Copy link
Member

Description

--vaadin-input-field-background is applied both to vaadin-text-area and vaadin-text-field but --vaadin-input-field-hover-highlight is applied only for vaadin-text-field

Expected outcome

Should be styled in consistent way

Minimal reproducible example

Add:

--vaadin-input-field-background: yellow;
--vaadin-input-field-hover-highlight: red;

to text area and hover mouse

Steps to reproduce

As above

Environment

Vaadin version(s): 24.4.0-beta3
OS: Macos

Browsers

No response

@MarcinVaadin MarcinVaadin changed the title --vaadin-input-field-hover-highlight does not applied to vaadin-text-area --vaadin-input-field-hover-highlight is not applied to vaadin-text-area May 17, 2024
@web-padawan
Copy link
Member

I think it's related to #1384. As mentioned there, in vaadin-text-area we set hover background differently:

The text-field hover and activation effect is done using a pseudo element. That doesn’t work nicely with the scrollable container of the text-area. So, we are using a plain background-color transition for the text-area currently

:host(:hover:not([readonly]):not([focused]):not([invalid])) [part='input-field'] {
background-color: var(--lumo-contrast-20pct);
}

@yuriy-fix yuriy-fix added DX Developer experience issue requires new major This would be a breaking change labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Developer experience issue requires new major This would be a breaking change vaadin-text-area
Projects
None yet
Development

No branches or pull requests

3 participants