Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support browser for Firefox extensions #144

Open
danielrozenberg opened this issue Jul 3, 2020 · 4 comments
Open

Support browser for Firefox extensions #144

danielrozenberg opened this issue Jul 3, 2020 · 4 comments

Comments

@danielrozenberg
Copy link

Firefox extensions use browser, not chrome (though it supports both, MDN encourages using browser)
I tried just renaming all instances of chrome in the the files to browser but that didn't work - which is too bad because I wanted to send you a PR instead of filing an issue :)

Activating extension 'VaibhavVishal.web-extension' failed: Cannot find module '.browser/browserCompletionItemProvider'
Require stack:
- /home/daniel/.vscode/extensions/vaibhavvishal.web-extension-0.1.0/out/completionItemProviders.js
- /home/daniel/.vscode/extensions/vaibhavvishal.web-extension-0.1.0/out/extension.js
- /usr/share/code/resources/app/out/vs/loader.js
- /usr/share/code/resources/app/out/bootstrap-amd.js
- /usr/share/code/resources/app/out/bootstrap-fork.js

(yes I also renamed every file containing the name chrome to browser)

@danielrozenberg
Copy link
Author

Update: it worked when I cloned your repo and did the same change. It just didn't work when I changed it in the already-compiled extension 🙃

@vaibhavhrt
Copy link
Owner

@danielrozenberg does both chrome & firefox extensions supports browser?
I haven't looked at the project for a while, I will take a look on weekend

@danielrozenberg
Copy link
Author

Chrome only supports chrome, Firefox supports browser and chrome (the latter is an alias to the former), other browsers (Edge, Safari) support browser, I don't know if they support chrome too...

@vaibhavhrt
Copy link
Owner

hmm, in that case I will try to add autocomplete for both chrome & browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants