Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded vals sometimes fail to load #133

Open
Xkonti opened this issue Feb 13, 2024 · 1 comment
Open

Embedded vals sometimes fail to load #133

Xkonti opened this issue Feb 13, 2024 · 1 comment

Comments

@Xkonti
Copy link
Contributor

Xkonti commented Feb 13, 2024

Embedded vals sometimes fail to load, which leads to confusion. Often a refresh works, but sometimes it takes more than one.

https://discord.com/channels/1020432421243592714/1020432421243592717/threads/1206842458554634240

There are 2 approaches possible:

  • Replace existing embeds with code blocks - this is the most stable approach, but it doesn't enable browser preview
  • Improve embeds' stability - something probably outside of the docs
@maxmcd
Copy link
Member

maxmcd commented Feb 13, 2024

I ran into a similar issue where a val.town embed was returning a 401 because my jwt had expired and the error page was returning x-frame-options:deny. Visiting val.town and then returning to the embed fixed things.

Might want to gracefully handle auth failures in vals and not deny the iframe on embed error responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants