Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tax categories #13

Open
erasmus opened this issue May 24, 2019 · 5 comments
Open

Introduce tax categories #13

erasmus opened this issue May 24, 2019 · 5 comments

Comments

@erasmus
Copy link
Contributor

erasmus commented May 24, 2019

I appreciate that you reduce the complexity of international tax by assuming services as the standard GST/VAT category, but it would be great to include the additional rates from the EY overview in the JSON and allow for querying those too for a more flexible lookup.

Is this something you've considered?

@valeriansaliou
Copy link
Owner

Just to confirm: you'd like to be able to get reduced VAT rates from node-sales-tax, is that right?

@erasmus
Copy link
Contributor Author

erasmus commented May 24, 2019

Yes

@valeriansaliou
Copy link
Owner

Gotcha. Not planned on my end (as I have no use for such a feature), but I'm definitely open to PRs on this (should not be too long to implement!).

@valeriansaliou
Copy link
Owner

(keeping this open)

@valeriansaliou
Copy link
Owner

Tax rate details are now being returned, aside of the total tax rate used. In states where the federal and local tax rates are being used, this will return both separate taxes, with their type (eg. HST, GST, etc.): https://github.com/valeriansaliou/node-sales-tax/blob/master/CHANGELOG.md#220-2020-06-12

Does this address your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants