fix reply schema and add fast path to return noscript err

Change-Id: Ia756dc5db4ebad5c83b4cc3b7f4a6702f94cfca4 Signed-off-by: wei.kukey <wei.kukey@gmail.com>
valkey-io · Jun 13, 2024 · 231e80c · 231e80c
1 parent ea81d56
commit 231e80c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/commands/script-dump.json b/src/commands/script-dump.json
@@ -26,8 +26,8 @@
                     "type": "string"
                 },
                 {
-                    "description": "null if sha1 hash does not exist in script cache.",
-                    "type": "null"
+                    "description": "noscript error if sha1 hash does not exist in script cache.",
+                    "const": "NOSCRIPT No matching script."
                 }
             ]
         }

diff --git a/src/eval.c b/src/eval.c
@@ -734,7 +734,7 @@ NULL
         dictEntry *de;
         luaScript *ls;
 
-        if ((de = dictFind(lctx.lua_scripts, c->argv[2]->ptr))) {
+        if (sdslen(c->argv[2]->ptr) == 40 && (de = dictFind(lctx.lua_scripts, c->argv[2]->ptr))) {
             ls = dictGetVal(de);
             addReplyBulk(c, ls->body);
         } else {