Fix-all-the-little-inconsistencies-in-the-json-command-file-descriptions #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ItsAJ1005 <ajharshvardhan123@gmail.com>
|
If you like my work, please review! |
PingXie
reviewed
Mar 31, 2024
| @@ -23,7 +23,7 @@ | |||
| }, | |||
| { | |||
| "type": "string", | |||
| "description": "The description of the problem, in case the user is not allowed to run the given command." | |||
| "description": "The description of the problem in case the user is not allowed to run the given command." | |||
There was a problem hiding this comment.
should we replace "in case" with "if" here too?
PingXie
reviewed
Mar 31, 2024
| @@ -15,7 +15,7 @@ | |||
| ], | |||
| "reply_schema": { | |||
| "type": "string", | |||
| "description": "Pseudorandom data. By default it contains 64 bytes, representing 256 bits of data. If `bits` was given, the output string length is the number of specified bits (rounded to the next multiple of 4) divided by 4." | |||
| "description": "Pseudorandom data. By default, it contains 64 bytes, representing 256 bits of data. If `bits` was given, the output string length is the number of specified bits (rounded to the next multiple of 4) divided by 4." | |||
There was a problem hiding this comment.
should we remove "," in the phrase below too?
it contains 64 bytes, representing 256 bits of data
|
Thanks @ItsAJ1005! Really appreciate the attention to details. |
|
#63 is ready to merge. Just waiting for broken file names (redis-cli is used in a python script) |
|
@ItsAJ1005 I merged #63. Sorry for causing you merge conflicts but that PR was already reviewed and ready to merge. I hope you can resolve them easily enough. |
ItsAJ1005
deleted the
Fix-all-the-little-inconsistencies-in-the-json-command-file-descriptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am new to open-source contribution and have attempted to make some minor changes. I would greatly appreciate a review from your side. Thank you!