Fix shutdown syntax hint, following intention #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiiNen
changed the title
LiiNen
force-pushed
the
fix-shutdown-hint
branch
from
d11fbff to
e6b4040
Compare
|
Spellcheck seems weird...? |
|
typos has been improved. It has found new errors, and some new false positives. |
Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
LiiNen
force-pushed
the
fix-shutdown-hint
branch
from
e6b4040 to
86dce25
Compare
|
force pushed it with rebase |
zuiderkwast
approved these changes
Apr 2, 2024
|
Thanks @LiiNen! It is also OK to add merge commits instead of rebase. We squash-merge it in the end anyway. Note that the merge-commit also needs the signed-off-by header though. |
|
Got it thanks, |
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
Change syntax hint from
SHUTDOWN [NOSAVE | SAVE] [NOW] [FORCE] [ABORT]
to
SHUTDOWN [[NOSAVE | SAVE] [NOW] [FORCE] | ABORT]
It's not that important for docs, but the latter is preferred for valkey-cli's automatic syntax hints.
Signed-off-by: LiiNen <kjeonghoon065@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is the thing I suggested to redis when it was BSD, and thankfully was reviewed by @zuiderkwast
Problem
valkey-cli, for now, is not fancy I thought.
The intention was that we cannot use 'ABORT' option with others - this only can be used alone.
But for now the hints show us that we can use it together, though this actually leads syntax error.
solved
simply fix hint
ABORT will not be appeared when others
other options will not be appeared when using ABORT
Note
Of course, I did refer to previous commit, but didn't fully reuse it.
I edit json, build, and check it certainly again :)
Thanks valkey!
p.s. when testing it, found the left word 'Redis' from first line in above img. Renaming redis to valkey is already in lots of PR, so I had checked previous PRs, and found PR that covered most of it, but not covering this phrase: 'Redis version=255.255.255'. Left suggestion comment in #88