Untrademark json files #35
Conversation
| @@ -43,7 +43,7 @@ | |||
| } | |||
| ], | |||
| "reply_schema": { | |||
| "description": "the number of clients that received the message. Note that in a Redis Cluster, only clients that are connected to the same node as the publishing client are included in the count", | |||
| "description": "the number of clients that received the message. Note that in a Cluster, only clients that are connected to the same node as the publishing client are included in the count", | |||
There was a problem hiding this comment.
(Not a blocker here) This documentation sits wrong with me, since this is like, only for cluster mode. @hpatro maybe take a look at this and fix it later?
There was a problem hiding this comment.
Good point, but let's not get stuck on these details.
We could also use the word "cluster" meaning a whole cluster (all the nodes) and "cluster-enabled" when we're talking about the configured mode of the current node.
There was a problem hiding this comment.
@madolson didn't follow you exactly, SPUBLISH also works in standalone mode.
There was a problem hiding this comment.
Yes. the behavior is the same for both cluster and non-cluster though right? It's only the name of clients connected to the current node. I guess the documentation on publish is also weird.
There was a problem hiding this comment.
Yeah, we can get rid of Note that in a Cluster.
Replaces valkey-io#26 Name agnostic. Now without spelling errors, ready to merge if you ask me.
Replaces #26
Name agnostic. Now without spelling errors, ready to merge if you ask me.