Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure & Improve TZDB Processing #2

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

vamsii777
Copy link
Owner

@vamsii777 vamsii777 commented Nov 21, 2024

Overview

This PR introduces significant improvements to timezone handling.

Key Changes

  • Dual-Source Timezone Parsing: The library now supports dual-source timezone parsing, utilizing both zonenow.tab and zone1970.tab files for timezone information.
  • Type Differentiation: The library has been enhanced to differentiate between current and historical timezones, facilitating more accurate timezone handling.
  • Improved PKL Schema Generation: The PKL schema generation process has been refined, incorporating improved type handling to ensure data integrity.

⚠️ Breaking Changes

  • Removed Linux test workflow (will be reintroduced in future release)
  • Modified timezone identifier structure to support both current and historical zones

Testing

  • ❌ All macOS tests passing
  • ✅ Timezone generation verified with both current and historical data
  • ✅ TZDB update automation tested with sample data

Follow-up Tasks

  • Reintroduce Linux testing in future release
  • Consider adding timezone metadata API

@vamsii777 vamsii777 merged commit 0d83be2 into main Nov 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant