Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental install from old bioclite repo. #21

Open
j-e-hunter opened this issue Jul 10, 2017 · 4 comments
Open

Accidental install from old bioclite repo. #21

j-e-hunter opened this issue Jul 10, 2017 · 4 comments
Assignees
Labels

Comments

@j-e-hunter
Copy link
Contributor

Default instructions on the github for downloading lobstahs from Bioconductor do not check that your local version of bioclite is up to date. This meant I installed a very old version of LOBSTAHS and then ran into errors.

@jamesrco
Copy link
Member

So I did already make some updates last week to both the vignette (e5e8e04) and entry-page README.md (742870f; version bump in 8012311) that instruct users to ensure they are running the latest version of Bioconductor, if trying to install from Bioconductor. This will be a hard one to catch with a test in the code itself, unless @lee-t has some ideas. Is there a way to insert some code someplace so LOBSTAHS checks to see if a more recent version of itself exists someplace, and then alerts the user to such?

@lee-t
Copy link
Contributor

lee-t commented Jul 10, 2017

One of the issues with R is that there is clear lack of indication as to whether or not a loaded repo url is up-to-date. That is, when a package loads, there is no information to say whether or not the repo is current or a version behind (out of date).

We could add a check, but that will require something that checks the pkgInfo in Bioconductor to ensure the proper version. Alternatively, we could host a version file on our own webserver or on Git and ask the code to check that first.

@jamesrco
Copy link
Member

Ugh, it's so true. Not a great design.

@jamesrco
Copy link
Member

I like both of those ideas though, Tyrone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants