Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup windows not being supressed anymore #92

Open
diegommm opened this issue Apr 19, 2016 · 6 comments
Open

Popup windows not being supressed anymore #92

diegommm opened this issue Apr 19, 2016 · 6 comments
Labels

Comments

@diegommm
Copy link

I have setup "extensions.masterPasswordPlus.suppress" to "2" and, as the title says, all popup windows asking for the Master Password are showed up and even stack up. I haven't messed up with the configuration in "about:config" yet, and I don't intend to unless required.
Using:

  • LUbuntu Linux 14.04, up to date.
  • Firefox 45.0.1, up to date according to the repos.
  • Master Password+ 1.21.6, up to date according to Firefox.
@diegommm diegommm changed the title Pop-up windows not being supressed anymore Popup windows not being supressed anymore Apr 19, 2016
@vanowm vanowm added the bug label Apr 19, 2016
@vanowm
Copy link
Owner

vanowm commented Apr 19, 2016

Anything in the error console?

@diegommm
Copy link
Author

How would I check that? I thought the error console would just throw errors for the currently displaying page.

-----Mensaje original-----
De: "V@no" notifications@github.com
Enviado el: ‎18/‎04/‎2016 22:02
Para: "vanowm/MasterPasswordPlus" MasterPasswordPlus@noreply.github.com
CC: "diegommm" diegoaugustomolina@gmail.com
Asunto: Re: [vanowm/MasterPasswordPlus] Popup windows not being supressedanymore (#92)

Anything in the error console?

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@vanowm
Copy link
Owner

vanowm commented Apr 19, 2016

That is web console you are referring to.

Try CTRL + SHIFT + J

@diegommm
Copy link
Author

I have Sync set up, so every time I open FF I'm prompted for the MP about 5
to 10 seconds after FF shows up. To clear all jitter from other pages, I
closed FF and opened it. After that, and before the MP popup appears, I
opened the error console as you instructed me.
There are lots of things there, so I clear that out and look wait for the
MP prompt. There's some seconds of silence before the prompt and nothing is
thrown to the error console when the MP prompts shows up. When I cancel it
it says the following:

TypeError: listener is not a non-null object
RemoteAddonsParent.jsm:608:3Sync encountered an error - see about:sync-log
for the log file. policies.js:677:0

I can realize the last one is Sync failing due to the obvious. When I click
in "RemoteAddonsParent.jsm:608:3" It takes me to
"view-source:resource://gre/modules/RemoteAddonsParent.jsm" and a line is
highlighted inside a function. The code of the function is:

// This function returns a listener that will not fire on events where//
the target is a remote xul:browser element itself. We'd rather let// the
child process handle the event and pass it up via// EventTargetParent.var
filteringListeners = new WeakMap();function
makeFilteringListener(eventType, listener){ if
(filteringListeners.has(listener)) { return
filteringListeners.get(listener); } // Some events are actually targeted
at the element // itself, so we only handle the ones where know
that won't happen. let eventTypes = ["mousedown", "mouseup", "click"]; if
(eventTypes.indexOf(eventType) == -1) { return listener; } function
filter(event) { let target = event.originalTarget; if (target
instanceof Ci.nsIDOMXULElement && target.localName == "browser" &&
target.isRemoteBrowser) { return; } if ("handleEvent" in
listener) { listener.handleEvent(event); } else {
listener.call(event.target, event); } }
filteringListeners.set(listener, filter); // THIS IS THE HIGHLIGHTED LINE
return filter;}


ES: Por favor, evite adjuntar documentos de Microsoft Office. Serán
desestimados.
EN: Please, avoid attaching Microsoft Office documents. They shall be
discarded.
LINK: http://www.gnu.org/philosophy/no-word-attachments.html

2016-04-19 8:32 GMT-03:00 V@no notifications@github.com:

That is web console you are referring to.

Try CTRL + SHIFT + J


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#92 (comment)

@bremich
Copy link

bremich commented Apr 23, 2016

I have the same issue - the password popup is not being supressed. This is what I get in the console:

TypeError: context is null frameModule.js:235:14

TypeError: listener is not a non-null object RemoteAddonsParent.jsm:608:3

NS_ERROR_ABORT: User canceled master password entry crypto-SDR.js:144:0

A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Sat Apr 23 2016 20:15:37 GMT+0200
Full Message: User canceled master password entry
Full Stack: JS frame :: resource://gre/components/crypto-SDR.js :: LoginManagerCrypto_SDR.prototype.decrypt :: line 144
JS frame :: resource://gre/components/storage-json.js :: _decryptLogins :: line 571
JS frame :: resource://gre/components/storage-json.js :: findLogins :: line 449
JS frame :: resource://gre/components/nsLoginManager.js :: LoginManager.prototype.findLogins :: line 378
JS frame :: resource://gre/modules/LoginManagerParent.jsm :: LoginManagerParent.sendLoginDataToChild< :: line 338
JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 315

@aardbol
Copy link

aardbol commented Apr 5, 2017

I can verify the same issue. Happens every time the browser is started, but also at othermoments.
A screenshot of the console:
https://image.tf/show/JJoCPTRU4y0bnbsW

Note that this only happens in Linux, not Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants