Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI issue on embeded YouTube video on Twitter even when skipping is not enabled. #132

Open
gepz opened this issue Nov 12, 2022 · 1 comment
Open

UI issue on embeded YouTube video on Twitter even when skipping is not enabled. #132

gepz opened this issue Nov 12, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@gepz
Copy link

gepz commented Nov 12, 2022 •
edited
Loading

Describe the bug
The extension causes UI issue on Twitter even when not enabled.
The embedded YouTube video always looks like this while playing, with the skip function enabled or not.

image

To Reproduce
Find any embedded YouTube video on Twitter and click to play it.

Expected behavior
The extension doesn't effect the UI.

Screenshots
The extension causes UI issue by prepend an empty div into the first layer of a nested iframe, the div is 100% height due to the style section in the outer iframe, and thus pushes the YouTube iframe downward and thus hiding it due to overflow.
image
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Firefox 106
  • Skip Silence Version 5

Additional context
@gepz gepz added the bug Something isn't working label Nov 12, 2022
@jyomu
Copy link

jyomu commented Dec 30, 2023

Similar problem with embedded twitch videos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jyomu @gepz