Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you run sctl too many times successively, github api will ratelimit #59

Open
marcoceppi opened this issue Mar 25, 2020 · 1 comment

Comments

@marcoceppi
Copy link
Contributor

Currently if you're running sctl in a lot of loops you can trigger the github ratelimit for unauthenticated API:

INFO[0002] failed to check for latest version: GET https://api.github.com/repos/vapor-ware/sctl/tags: 403 API rate limit exceeded for 108.56.192.95. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 30m13s]

I don't think this is a bad thing, but I do think the logging should be lowered so it's not included in default output.

@lazypower
Copy link
Contributor

ah, this is on the update check 🤔 good point. we didn't want to just swallow that output when we initially landed it 🤔 we may need a better qualifier for when to surface a failed update check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants