Skip to content

Remove content length header on initial handshake
Compare
Choose a tag to compare
@VaporBot VaporBot released this 28 Mar 17:04
· 27 commits to main since this release
2.3.1
e32033a
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.
This patch was authored by @GNMoseke and released by @0xTim.

This removes the content-length: 0 header being automatically applied to outgoing websocket handshakes.

As per RFC 7230 Section 3.3.2:

A user agent SHOULD NOT send a
Content-Length header field when the request message does not contain
a payload body and the method semantics do not anticipate such a
body.

This was causing issues with certain cloud providers, most notably Google Cloud Run, that would force close the websocket as soon as data was received from a client.

Contributors

0xTim and GNMoseke
Assets 2
Loading