Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small comments on .gitignore #4

Open
erikdao opened this issue Jul 28, 2021 · 1 comment
Open

Small comments on .gitignore #4

erikdao opened this issue Jul 28, 2021 · 1 comment

Comments

@erikdao
Copy link

erikdao commented Jul 28, 2021

Dear authors,

Thank you very much for sharing the source code of the paper. Indeed, the method presented in the paper is very interesting and the results look promising.
I have two small comments regarding the organization of this repository. I could see that python compiled files (i.e., .pyc, __pycache__) and Jupyter notebook checkpoints (i.e., .ipython_checkpoints) are also committed to this repo. I believe the standard practice is to not include these files in a Git repository.
Additionally, I think it would be helpful to include a requirements.txt listing the required python packages to run this repo. I would be more than happy to open a pull request for these changes.

My 2 cents!
Best,

@vasgaowei
Copy link
Owner

Thanks for your response, it would be nice if you help refine this repository. Looking forward to your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants