Fix agc trigger

vballoli · Mar 3, 2021 · bf8ee3b · bf8ee3b
1 parent 2f88915
commit bf8ee3b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/nfnets/agc.py b/nfnets/agc.py
@@ -68,7 +68,7 @@ def step(self, closure=None):
                 grad_norm = unitwise_norm(p.grad.detach())
                 max_norm = param_norm * group['clipping']
 
-                trigger = grad_norm < max_norm
+                trigger = grad_norm > max_norm
 
                 clipped_grad = p.grad * \
                     (max_norm / torch.max(grad_norm,

diff --git a/nfnets/sgd_agc.py b/nfnets/sgd_agc.py
@@ -107,7 +107,7 @@ def step(self, closure=None):
                 grad_norm = unitwise_norm(p.grad.detach())
                 max_norm = param_norm * group['clipping']
 
-                trigger = grad_norm < max_norm
+                trigger = grad_norm > max_norm
 
                 clipped_grad = p.grad * \
                     (max_norm / torch.max(grad_norm,

diff --git a/setup.py b/setup.py
@@ -8,7 +8,7 @@
 setup(
   name = 'nfnets-pytorch',
   packages = find_packages(),
-  version = '0.0.8',
+  version = '0.0.9',
   license='MIT',
   description = 'NFNets, PyTorch',
   long_description=long_description,