From d34f1fbf2f05b5fe3b5cbb9259e630ee8318850c Mon Sep 17 00:00:00 2001 From: Vben Date: Sat, 21 Sep 2024 13:25:06 +0800 Subject: [PATCH] fix: improve defineConfig types (#4454) --- internal/vite-config/src/typing.ts | 4 ++-- packages/@core/ui-kit/form-ui/__tests__/form-api.test.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/vite-config/src/typing.ts b/internal/vite-config/src/typing.ts index 7505ab3eb4a..37da46d2b44 100644 --- a/internal/vite-config/src/typing.ts +++ b/internal/vite-config/src/typing.ts @@ -137,12 +137,12 @@ type ApplicationOptions = ApplicationPluginOptions; type LibraryOptions = LibraryPluginOptions; -type DefineApplicationOptions = (config?: ConfigEnv) => Promise<{ +type DefineApplicationOptions = (config: ConfigEnv) => Promise<{ application?: ApplicationOptions; vite?: UserConfig; }>; -type DefineLibraryOptions = (config?: ConfigEnv) => Promise<{ +type DefineLibraryOptions = (config: ConfigEnv) => Promise<{ library?: LibraryOptions; vite?: UserConfig; }>; diff --git a/packages/@core/ui-kit/form-ui/__tests__/form-api.test.ts b/packages/@core/ui-kit/form-ui/__tests__/form-api.test.ts index be9bcc7dbaa..d61627d9d78 100644 --- a/packages/@core/ui-kit/form-ui/__tests__/form-api.test.ts +++ b/packages/@core/ui-kit/form-ui/__tests__/form-api.test.ts @@ -183,7 +183,7 @@ describe('updateSchema', () => { instance.updateSchema(newSchema); expect(consoleErrorSpy).toHaveBeenCalledWith( - 'All children of the form Schema array that need to be updated must contain the `field` field', + 'All items in the schema array must have a valid `fieldName` property to be updated', ); });