Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to vega-lite-dev-config #81

Open
domoritz opened this issue Dec 2, 2019 · 2 comments
Open

Switch to vega-lite-dev-config #81

domoritz opened this issue Dec 2, 2019 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@domoritz
Copy link
Member

domoritz commented Dec 2, 2019

See https://github.com/vega/vega-embed/blob/master/package.json#L50 for an example.

The advantage would be that we can share the same dev config across all projects.
@domoritz domoritz added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 2, 2019
@DhananjayPurohit
Copy link

I want to work on this issue. Can you please guide me more about the same?

@domoritz
Copy link
Member Author

@DhananjayPurohit Awesome. Essentially, the idea is that we want to share the dev config among projects. This means that we don't check in the configs but instead they get pulled from npm. Try to develop vega embed locally and you'll see what I mean. Let me know if you have any specific questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domoritz @DhananjayPurohit