Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the default shell on Windows #8041

Open
jaraco opened this issue Oct 2, 2024 · 3 comments
Open

Allow overriding the default shell on Windows #8041

jaraco opened this issue Oct 2, 2024 · 3 comments

Comments

@jaraco
Copy link

jaraco commented Oct 2, 2024

Is your feature request related to a problem? Please describe.
On Unix, I can chsh the default shell to my preferred shell and Hyper will honor that.

On Windows, there's no way to configure a default shell, as far as I can tell. I've tried overriding the COMSPEC variable, but that has no effect on Hyper.

I'd like not to have to configure the default shell in the configuration file as I'd like to re-use the same configuration file that I use on other platforms.

Describe the solution you'd like
Ideally, the user could configure something in the environment to change the default shell (e.g. DEFAULT_SHELL=%userprofile%/.local/bin/myshell.exe), and Hyper would honor that.

@jaraco
Copy link
Author

jaraco commented Oct 2, 2024

On further examination, I determined that the default-shell package as used by Hyper does honor COMSPEC. I must have done something wrong the first time I tried. I was able to configure COMSPEC in my environment and now Hyper loads that shell even when shell: '',.

@jaraco jaraco closed this as completed Oct 2, 2024
@jaraco jaraco reopened this Oct 7, 2024
@jaraco
Copy link
Author

jaraco commented Oct 7, 2024

On further consideration, while setting COMSPEC does in fact allow Hyper to launch a different shell, it also breaks other things that expect COMSPEC to refer to a cmd.exe-compatible shell, so setting it to my shell breaks those applications. It would be nice to be able to define an alternate default shell, maybe just for Hyper, but without affecting applications reliant on COMSPEC.

@jmanuel1
Copy link

jmanuel1 commented Oct 9, 2024

On 3.4.1 I can set my preferred shell to powershell by overriding shell in the config file. Is that what you're looking for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants