Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tui when searching with /, h will still hide the task list #9553

Closed
1 task done
macrozone opened this issue Dec 3, 2024 · 1 comment · Fixed by #9558
Closed
1 task done

tui when searching with /, h will still hide the task list #9553

macrozone opened this issue Dec 3, 2024 · 1 comment · Fixed by #9558
Assignees
@chris-olszewski
Labels
kind: bug Something isn't working

Comments

@macrozone
Copy link

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

none

Which canary version will you have in your reproduction?

2.3.3

Enviroment information

CLI:
   Version: 2.3.3
   Path to executable: /Users/macrozone/git/panter/food-2050/node_modules/turbo-darwin-arm64/bin/turbo
   Daemon status: Running
   Package manager: berry

Platform:
   Architecture: aarch64
   Operating system: macos
   WSL: false
   Available memory (MB): 22675
   Available CPU cores: 12

Environment:
   CI: None
   Terminal (TERM): xterm-256color
   Terminal program (TERM_PROGRAM): iTerm.app
   Terminal program version (TERM_PROGRAM_VERSION): 3.5.10
   Shell (SHELL): /bin/zsh
   stdin: false

Expected behavior

should not hide when searching

Actual behavior

hides when searching

To Reproduce

press /

press h

Additional context

No response
@macrozone macrozone added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Dec 3, 2024
@chris-olszewski chris-olszewski removed the needs: triage New issues get this label. Remove it after triage label Dec 4, 2024
@chris-olszewski chris-olszewski mentioned this issue Dec 4, 2024
Merged
@chris-olszewski
Copy link
Member

This was fixed in #9543 which will be released in 2.3.4-canary.0

chris-olszewski added a commit that referenced this issue Dec 4, 2024
@chris-olszewski
chore(tui): add test for key handling (#9558)
d985382 
### Description

Before I realized that #9543
already fixed #9553 I started
working on a unit test for this section of the code. Putting it up just
so writing future tests should be easier.

### Testing Instructions

Unit test runs and passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chris-olszewski chris-olszewski

Labels
kind: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(tui): add test for key handling vercel/turborepo
2 participants
@macrozone @chris-olszewski