Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Before and @After do not work #4

Open
ewolff opened this issue Jun 30, 2013 · 6 comments
Open

@Before and @After do not work #4

ewolff opened this issue Jun 30, 2013 · 6 comments

Comments

@ewolff
Copy link

ewolff commented Jun 30, 2013

@before and @after annotations as known from JUnit do not work
@BeforeClass do work, however.

https://gist.github.com/ewolff/5894732 fails in beforeIsExecuted()
https://gist.github.com/ewolff/5894741 fails in afterClass()

I am running the tests in the test-tools-tests project commit 493fa1314565173ecac2ed8fb5438e358cb687ce .

@RichardWarburton
Copy link
Contributor

+1 for fixing this.

@purplefox
Copy link
Member

We only support the @test annotation and the Junit assert API in test tools.
http://vert-x.github.io/dev_guide.html#integration-tests

@RichardWarburton
Copy link
Contributor

Thanks for replying @purplefox

I appreciate that you're only supporting the @test annotation at the moment, but are you saying that you would reject pull requests that implement @before and @after functionality as well?

@purplefox
Copy link
Member

Pull requests are always welcome :)

@RichardWarburton
Copy link
Contributor

@purplefox if I implement this, I've got an open design question:

Since the test class is now a verticle and thus performs comms/io etc asynchronously any implementation of the @Before and @After methods need to have a way of signalling that they complete. In normal tests this is achieved by a call to VertxAsserts.testComplete(). Would you want these methods to follow the same model?

@ddossot
Copy link

ddossot commented Jun 24, 2014

+1 for fixing this, at least for v3 😄

Supporting @Rule would be great too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants