Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renew Session for session expired & reconnect connection of session for IOError #276

Closed
Nicole00 opened this issue Jun 27, 2023 · 3 comments · Fixed by #306
Closed

renew Session for session expired & reconnect connection of session for IOError #276

Nicole00 opened this issue Jun 27, 2023 · 3 comments · Fixed by #306
Labels
HACKTOBERFEST type/enhancement Type: make the code neat or more efficient

Comments

@Nicole00
Copy link
Contributor

add re-execute operation, before re-execute, we should renew the session if the failure is E_SESSION_INVALID or E_SESSION_TIMEOUT, and we should reconnect the session's connection for IO Error, and just re-execute for E_EXECUTION_ERROR.

Don't retry for E_STATEMENT_EMPTY and E_SYNTAX_ERROR.
@Nicole00 Nicole00 added the type/enhancement Type: make the code neat or more efficient label Jun 27, 2023
@wey-gu
Copy link
Contributor

wey-gu commented Jun 27, 2023

Sure, I can do this :) @Nicole00

@wey-gu
Copy link
Contributor

wey-gu commented Jun 27, 2023

#275

@wey-gu
Copy link
Contributor

wey-gu commented Aug 8, 2023 •
edited
Loading

like implementations from, with (exponential)backoff-wise retry based on different exceptions.

https://github.com/jerryjliu/llama_index/blob/c528cf6857193a6056cfb2d77666ba3c5659750b/llama_index/graph_stores/nebulagraph.py#L170

wey-gu added a commit to wey-gu/nebula-python that referenced this issue Jan 8, 2024
@wey-gu
feat: renew session for expiration, re-execute when error
38b2f27 
close: vesoft-inc#276
@wey-gu wey-gu mentioned this issue Jan 8, 2024
Merged
3 tasks
wey-gu added a commit that referenced this issue Jan 10, 2024
@wey-gu
feat: renew session for expiration, re-execute when error
b562bb2 
close: #276
wey-gu added a commit to wey-gu/nebula-python that referenced this issue Mar 4, 2024
@wey-gu
feat: renew session for expiration, re-execute when error
ba27e4c 
close: vesoft-inc#276
Nicole00 pushed a commit that referenced this issue Mar 4, 2024
@wey-gu
feat: renew session for expiration, re-execute when error (#306)
f57b253 
* feat: renew session for expiration, re-execute when error

close: #276

* ci: pdm fmt

make black happy

* fix: test cases failure

* fix ssl cases

* feat: add retry interval in seconds for seesion retry

* chore: comments for py3.6 build from source ci

* fix: missing sleep for json execution

addressing review comments by @Nicole00

* fix: ci in py3.12

due to https://peps.python.org/pep-0632/

* call py3.12 examples without pdm

* fix: remove pdm in example run

due to 3.12 setuptools cannot fit >=py3.6.2

* use pip to build from source

* fix: add dev and test group pdm installation
@github-project-automation github-project-automation bot moved this from Todo to Done in hacktoberfest 2023 Mar 4, 2024
@wey-gu wey-gu mentioned this issue Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HACKTOBERFEST type/enhancement Type: make the code neat or more efficient
Projects
hacktoberfest 2023
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: renew session for expiration, re-execute when error wey-gu/nebula-python
2 participants
@wey-gu @Nicole00