Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate NatTable for HighDPI #140

Closed
ShahzaibIbrahim opened this issue Nov 5, 2024 · 1 comment
Closed

Investigate NatTable for HighDPI #140

ShahzaibIbrahim opened this issue Nov 5, 2024 · 1 comment
Assignees
@ShahzaibIbrahim
Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Milestone
4.34 M3

Comments

@ShahzaibIbrahim
Copy link

ShahzaibIbrahim commented Nov 5, 2024 •
edited
Loading

Investige and adapt the NatTable (https://github.com/eclipse-nattable/nattable) in the context of HighDPI change #32, #33 and #34
@ShahzaibIbrahim ShahzaibIbrahim self-assigned this Nov 5, 2024
@ShahzaibIbrahim ShahzaibIbrahim converted this from a draft issue Nov 5, 2024
@ShahzaibIbrahim ShahzaibIbrahim added the SWT Issue for SWT label Nov 5, 2024
@ShahzaibIbrahim ShahzaibIbrahim changed the title Investigate Nebula Widget for HighDPI Investigate NatTable for HighDPI Nov 5, 2024
@ShahzaibIbrahim ShahzaibIbrahim added the HiDPI A HiDPI-Related Issue or Feature label Nov 5, 2024
@akoch-yatta akoch-yatta added this to the 4.34 M3 milestone Nov 8, 2024
@ShahzaibIbrahim
Copy link
Author

During the testing, I have found example to be bit weird in scaling with or without HiDpi changes. In the ._102_Configuration.AutomaticRowHeightExample the image remains the same size i.e. 16px while the text and the column height is being adjusted a/c to zoom level of the current monitor. That is because of wrong implementation with GUIHelper.convertHorizontalPixelToDpi(16); which is a part of NatTable repository. Not investigating further as this is not part of HiDpi in SWT and not introduced by enabling the HiDpi feature.

Image

@HeikoKlare @akoch-yatta

@github-project-automation github-project-automation bot moved this from 🏗 In Work: Short to ✅ Done in Eclipse Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShahzaibIbrahim ShahzaibIbrahim

Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Eclipse
Status: ✅ Done
Milestone
4.34 M3
Development

No branches or pull requests
2 participants
@ShahzaibIbrahim @akoch-yatta