Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Regression Test to PR#766 #24

Closed
fedejeanne opened this issue Nov 6, 2023 · 6 comments
Closed

Add Regression Test to PR#766 #24

fedejeanne opened this issue Nov 6, 2023 · 6 comments
Assignees
Labels
Bug A Derivation of Expected Behavior Platform Issue for Core Platform

Comments

@fedejeanne
Copy link

fedejeanne commented Nov 6, 2023

If possible, add a regression test for the changes in eclipse-platform/eclipse.platform#766. The test should make sure that the current tab is activated (i.e. that its activate method is called) when switching between Run Configurations in the Run Configurations Dialog

(Moved to eclipse-platform/eclipse.platform#1075)

@HeikoKlare
Copy link
Contributor

I propose to increase priority for this issue. The fix has been merged without an automated test and 4.30 release is about to come, so I suggest to provide a (regression) test before release,

@HeikoKlare HeikoKlare added Platform Issue for Core Platform Bug A Derivation of Expected Behavior labels Nov 9, 2023
@fedejeanne fedejeanne removed their assignment Nov 9, 2023
@fedejeanne
Copy link
Author

I'm ok with it, I just won't be working on it anytime soon since the changes were small and the functionality has been manually tested so I don't consider this a pressing matter.

I removed the assignee, this ticket can be re-prioritized and picked out.

@fedejeanne fedejeanne moved this from 🔖 Ready to 🏗 In progress in Eclipse Nov 13, 2023
@fedejeanne fedejeanne self-assigned this Nov 13, 2023
@fedejeanne fedejeanne moved this from 🏗 In Work: Short to 👀 In Review in Eclipse Nov 24, 2023
@fedejeanne
Copy link
Author

Waiting for eclipse-platform/eclipse.platform#860 to be merged

@fedejeanne fedejeanne moved this from 👀 In Review to ✅ Done in Eclipse Dec 13, 2023
@HeikoKlare
Copy link
Contributor

PR has been merged

@HeikoKlare
Copy link
Contributor

Added test is broken: eclipse-platform/eclipse.platform#1075

@HeikoKlare HeikoKlare reopened this Jan 19, 2024
@HeikoKlare HeikoKlare moved this from ✅ Done to 🕒 Waiting in Eclipse Jan 19, 2024
@HeikoKlare HeikoKlare changed the title Add regression test to PR#766 Add Regression Test to PR#766 Jan 19, 2024
@fedejeanne
Copy link
Author

fedejeanne commented Mar 27, 2024

PR created and sent for review (@HeikoKlare ?)

eclipse-platform/eclipse.platform#1268

@fedejeanne fedejeanne moved this from 🕒 Waiting to 👀 In Review in Eclipse Mar 27, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Eclipse Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A Derivation of Expected Behavior Platform Issue for Core Platform
Projects
Status: Done
Development

No branches or pull requests

2 participants