Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare PR for adaptions on Region in the context of multiple zoom levels #44

Closed
akoch-yatta opened this issue Mar 28, 2024 · 1 comment
Closed

Prepare PR for adaptions on Region in the context of multiple zoom levels #44

akoch-yatta opened this issue Mar 28, 2024 · 1 comment
Assignees
@amartya4256
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT

Comments

@akoch-yatta
Copy link

Create PR for org.eclipse.swt.graphics.Region with multiple zoom levels support on the basis of SWT master after merge of eclipse-platform/eclipse.platform.swt#1064. Conditions are:

  1. Minimal invasive: All changes should be checked under this condition. Prevent quality refactoring as much as possible or submit them in advance in a separate PR
  2. Minimal resources: If a OS handle must be allocated without a known defined zoom, the primary monitor zoom shall be used for this default handle.
  3. Tests: Add tests to verify the behaviour when the zoom changes
  4. Independence: The PR must rely directly on the SWT master.
@akoch-yatta akoch-yatta converted this from a draft issue Mar 28, 2024
@akoch-yatta akoch-yatta added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature Enhancement A Request for an Enhancement of an Existing Feature labels Mar 28, 2024
@amartya4256 amartya4256 moved this from 🔖 Ready: Atomic to 🏗 In Work: Short in Eclipse Apr 15, 2024
@amartya4256 amartya4256 moved this from 🏗 In Work: Short to 👀 In Review in Eclipse Apr 30, 2024
@akoch-yatta
Copy link
Author

eclipse-platform/eclipse.platform.swt#1278

@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Eclipse Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amartya4256 amartya4256

Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Eclipse
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amartya4256 @akoch-yatta