Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare PR for adaption on StyledText #60

Closed
akoch-yatta opened this issue May 17, 2024 · 2 comments
Closed

Prepare PR for adaption on StyledText #60

akoch-yatta opened this issue May 17, 2024 · 2 comments
Assignees
@amartya4256
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT

Comments

@akoch-yatta
Copy link

akoch-yatta commented May 17, 2024 •
edited
Loading

Create PR for StyledText. Conditions are:

Minimal invasive: All changes should be checked under this condition. Prevent quality refactoring as much as possible or submit them in advance in a separate PR
Tests: Add tests to verify the behaviour when the zoom changes

PR must probably be based on PR for #43
@akoch-yatta akoch-yatta converted this from a draft issue May 17, 2024
@akoch-yatta akoch-yatta added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature Enhancement A Request for an Enhancement of an Existing Feature labels May 17, 2024
@ShahzaibIbrahim ShahzaibIbrahim moved this from 🔖 Ready: Atomic to 🏗 In Work: Short in Eclipse May 24, 2024
@akoch-yatta akoch-yatta mentioned this issue Jun 24, 2024
Closed
10 tasks
@ShahzaibIbrahim
Copy link

Since its already addressed by @amartya4256 in eclipse-platform/eclipse.platform.swt#1294. Assigning it to him

@akoch-yatta
Copy link
Author

Merged in eclipse-platform/eclipse.platform.swt#1294

@github-project-automation github-project-automation bot moved this from 🏗 In Work: Short to ✅ Done in Eclipse Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amartya4256 amartya4256

Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Eclipse
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amartya4256 @ShahzaibIbrahim @akoch-yatta