Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search #31

Open
the-eater opened this issue May 7, 2023 · 1 comment
Open

Add search #31

the-eater opened this issue May 7, 2023 · 1 comment

Comments

@the-eater
Copy link

It would be helpful to have a search to quickly navigate between objects,

I did some rudimentary implementation in main...the-eater:wayland-explorer:add-search

but it's, kinda bad

@vially
Copy link
Owner

vially commented May 13, 2023

Thanks a lot for working on this. Search would be a really nice feature and it's been on my todo list for a while now but I just never got around to implementing it.

So if you ever have time to finish it off feel free to submit a PR and we'll take it from there.

One thing worth mentioning is that I would prefer, if possible, if the search implementation would work with JavaScript disabled too. I'm not sure if that's possible with lunr or if there are any alternatives that would make that easier. That being said, this is more of a nice-to-have and it will not be a hard-requirement for the initial version of the search implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants