Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode toggle #37

Open
chrisduerr opened this issue Aug 15, 2023 · 1 comment
Open

Add dark mode toggle #37

chrisduerr opened this issue Aug 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@chrisduerr
Copy link

As far as I can tell, wayland explorer already supports dark mode if the browser requests it. However in Firefox when enabling tracking protection it does not send this value.

It would be nice to still have a manual toggle, even if its state is not cached, just to give the option to go dark mode when looking at a protocol for extended periods of time.

This should also be useful for people that might have a light system scheme, but just prefer wayland explorer to use the dark mode (or the other way around).

@vially vially added the enhancement New feature or request label Aug 27, 2023
@vially
Copy link
Owner

vially commented Aug 27, 2023

Agree that this would be useful and it's something I would like to support. However, last time I have looked into it (#4 (review)) it seemed like Tailwind does not support both media and class based dark-mode at the same time: tailwindlabs/tailwindcss#3644.

So it's either class but lose the dark mode when JavaScript is disabled, or media but lose the ability to let the user overwrite it on a per-website basis.

That being said, it may be worth taking a closer look at it in case things have changed or I may have missed something last time I looked at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants