-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setMediaKeys not return promise on low Chrome version(<=38) #6663
Comments
The compatibility section of the README states that HLS.js is supported on Chrome 39 and up. https://github.com/video-dev/hls.js?tab=readme-ov-file#compatibility Would you like to submit a PR to avoid this escape, assuming that optional chaining resolves the exception described above Was media detached intentionally or is the exception described a result of tear-down after a larger compatibility related issue? |
Sorry about ignoring the compatibility document about the hls.js usage. And I would like to submit a PR to avoid the special case from your suggestion. |
What version of Hls.js are you using?
1.5.14
What browser (including version) are you using?
Chrome38.x
What OS (including version) are you using?
Mac OS
Test stream
https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine-hls/hls.m3u8
Configuration
Additional player setup steps
No response
Checklist
Steps to reproduce
https://hlsjs.video-dev.org/demo/?src=https%3A%2F%2Fstorage.googleapis.com%2Fshaka-demo-assets%2Fangel-one-widevine-hls%2Fhls.m3u8&demoConfig=eyJlbmFibGVTdHJlYW1pbmciOnRydWUsImF1dG9SZWNvdmVyRXJyb3IiOnRydWUsInN0b3BPblN0YWxsIjpmYWxzZSwiZHVtcGZNUDQiOmZhbHNlLCJsZXZlbENhcHBpbmciOi0xLCJsaW1pdE1ldHJpY3MiOi0xfQ==
in the special chrome versiondetach media
buttonExpected behaviour
No Error thrown
What actually happened?
Throw an error
catch in undefined
I guess it could be the line:
hls.js/src/controller/eme-controller.ts
Lines 1256 to 1259 in 01f50bb
media?.setMediaKeys(null)
returnundefined
here. We may remove thecatch
.Console output
Chrome media internals output
No response
The text was updated successfully, but these errors were encountered: