New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTT file with styles crashes the parser #5

Open

OrenMe opened this issue Nov 14, 2018 · 0 comments

OrenMe commented Nov 14, 2018

Assigning `localName' which is read only(MDN link) causes exception:

vtt.js/lib/vtt.js

Lines 377 to 380 in c77cd38

 var element = window.document.createElement(tagName); 

 element.localName = tagName; 

 var name = TAG_ANNOTATION[type]; 

 if (name && annotation) {

I don't see any reason to keep it, just remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment