Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple budo servers in parallel sometimes drop all styles #22

Open
jimdebeer opened this issue Apr 28, 2016 · 5 comments
Open

Multiple budo servers in parallel sometimes drop all styles #22

jimdebeer opened this issue Apr 28, 2016 · 5 comments
Assignees

Comments

@jimdebeer
Copy link
Contributor

pull element branch refactor/state

npm run example root
npm run example collection

these examples require the same css files -- weird stuff happens you'll see

@jimdebeer
Copy link
Contributor Author

jimdebeer commented Apr 28, 2016

seems something else -- also happens sometimes when not running 2 examples

@shawninder
Copy link
Contributor

shawninder commented Apr 28, 2016

Ok I'll check it

@shawninder
Copy link
Contributor

@jimdebeer I'm not seeing any weird stuff. What is it you expect to see that is not happening?

@shawninder shawninder changed the title Budo and multiple files Multiple budo servers in parralel sometimes drop all styles Apr 28, 2016
@shawninder
Copy link
Contributor

To reproduce, it's important to launch both npm run example root and npm run example collection at the same time. Then, make some changes to the CSS and save them. Repeat this last step until all styles disappear from on of the pages.

This might be a problem with budo itself, but that needs to be confirmed.

@shawninder shawninder changed the title Multiple budo servers in parralel sometimes drop all styles Multiple budo servers in parallel sometimes drop all styles Apr 28, 2016
@shawninder
Copy link
Contributor

shawninder commented Apr 28, 2016

I've reproduced this with a single budo process. I'm pretty sure this is because budo does its stuff when browserify is done, which doesn't mean the transform is done bundling the CSS. So at the time the browser downloads the CSS bundle, it's not ready, and budo doesn't know it has to wait because the JS part is indeed finished.

There is no issue for this but it's been on my radar since the beginning (this is partly why I started with a plugin, not a transform...). Notice the postcssify tests have a setTimeout to mitigate this issue until solving it becomes the priority. Since it breaks budo (and not only the tests), I will bump this back into top priority and do this next (now). But it's not going to be easy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants