Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Suggested Peers #38

Open
wandilemawelela opened this issue Oct 12, 2023 · 6 comments
Open

Support for Suggested Peers #38

wandilemawelela opened this issue Oct 12, 2023 · 6 comments

Comments

@wandilemawelela
Copy link

wandilemawelela commented Oct 12, 2023

New Suggested Peers Cards seem to lack support for Dark Mode.
Screenshot 2023-10-12 170517

@MartyOfMCA
Copy link
Collaborator

Hello @wandilemawelela, kindly provide the URL to this page so I take a look at it. Thank you!

@vinsky001
Copy link
Owner

Hello @wandilemawelela, kindly provide the URL to this page so I take a look at it. Thank you!

Thank you @MartyOfMCA mans is dying in this other side of specilizations plus side projects.

@wandilemawelela
Copy link
Author

Hello @wandilemawelela, kindly provide the URL to this page so I take a look at it. Thank you!

Sure...here https://intranet.alxswe.com/projects/249. I'm sure this is the case for every partner project.

@MartyOfMCA
Copy link
Collaborator

I checked the URL given and it redirected me to the Stacks, Queues - LIFO, FIFO project and it looks okay as indicated in the below photos:

image

image

image

And pretty much the same for the entire page. I would appreciate it if you could provide more context to help me identify what could be wrong. I viewed the link as a student who has completed that project. Perhaps that's why I'm unable to see this issue.

Thank you!

@wandilemawelela
Copy link
Author

I checked the URL given and it redirected me to the Stacks, Queues - LIFO, FIFO project and it looks okay as indicated in the below photos:

image

image

image

And pretty much the same for the entire page. I would appreciate it if you could provide more context to help me identify what could be wrong. I viewed the link as a student who has completed that project. Perhaps that's why I'm unable to see this issue.

Thank you!

Thank you for taking the time to review this. The issue at hand pertains specifically to the new suggested peers cards, as depicted in the screenshot I provided. Everything else seems to be functioning properly. Given that you have mentioned already completing the project, I understand that reproducing the issue might not be feasible for you, as it only appears for students who have not yet commenced the project. Similarly, I will be unable to replicate it once I have finished the project. However, I presume this issue may extend to all other partner projects on the intranet. I will attempt a pull request (PR) on a future project, as it is likely that the same problem may arise again.

@MartyOfMCA
Copy link
Collaborator

Wonderful idea @wandilemawelela Feel free to jump in so we build a better extension for all ALX SE students. We'll keep an eye out for this when we encounter any group projects as well.

Thanks a bunch! You have a great time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants