Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for type hints #58

Open
sshishov opened this issue Dec 6, 2023 · 6 comments
Open

Add support for type hints #58

sshishov opened this issue Dec 6, 2023 · 6 comments

Comments

@sshishov
Copy link

sshishov commented Dec 6, 2023

If yes, any possibility to add support of type hints? as DRF supports type hints but with the usage of this library, all the type checks vanished

@fjsj
Copy link
Member

fjsj commented Dec 11, 2023

Hi, yes. Feel free to open a PR with this support and we can launch a new version with it.

@sshishov
Copy link
Author

Great @fjsj , let me try to add type hints, as I have a test repo to validate it.
If we want to make sure that our type hints are correct, we have to have at least some kind of pipeline or tests...

@sshishov sshishov changed the title Is this repo still alive? Add support for type hints Dec 16, 2023
@fjsj
Copy link
Member

fjsj commented Dec 18, 2023

The tests used to run in Travis. We need to migrate to GitHub Actions, which shouldn't be too difficult. If you can, please feel free to include that in your PR.

@fjsj
Copy link
Member

fjsj commented Dec 18, 2023

@sshishov we'll migrate to GH Actions right now, no need to include that in your PR.

@sshishov
Copy link
Author

sshishov commented Jun 4, 2024

Hello,

currently we are using stubs file for our usage.

Do you prefer the "stubs" file or you want to include the typing in the code? Based on this I can create the MR.

NOTE: stubs is just *.pyi indicating types for classes, functions, modules.
For our codebase we are using the typing in-place, and we are using only Py3 support.
I guess more preferably would be to use in-place, but everyone has its own taste.

@fjsj
Copy link
Member

fjsj commented Jun 5, 2024

You can include typing in code directly in-place @sshishov
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants