-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPaymentPaymentEventOKResponse should not be an array #23
Comments
I will look into the Webhook event shortly |
@melanki : I updated the PR to add the missing Webhook type (for both ePayment and Qr). Will release a new version once it has been approved. |
tomas-zijdemans-vipps
added a commit
that referenced
this issue
Jan 15, 2024
* Fix epayment types to address: #23 * Add missing Webhook event types
Fixed in 0.7.0 |
Thank you for the quick response, will verify it later today. EDIT: Fix verified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
EPaymentPaymentEventOKResponse is wrongfully typed as an array of events.
If it is only intended for Payment Event History Response as commented in code, SDK should define a PaymentEvent object and EPaymentPaymentEventOKResponse should have an array of this object.
TL:DR; Missing PaymentEvent object
Expected behavior
Based on this documentation: https://developer.vippsmobilepay.com/docs/APIs/epayment-api/features/webhooks/
As a developer I expect to receive an object representing an event on my endpoint.
EPaymentPaymentEventOkResponse is wrongfully typed or SDK is missing an object for webhook events.
The text was updated successfully, but these errors were encountered: