Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPaymentPaymentEventOKResponse should not be an array #23

Closed
melanki opened this issue Jan 9, 2024 · 5 comments
Closed

EPaymentPaymentEventOKResponse should not be an array #23

melanki opened this issue Jan 9, 2024 · 5 comments
Assignees

Comments

@melanki
Copy link

melanki commented Jan 9, 2024

Describe the bug

EPaymentPaymentEventOKResponse is wrongfully typed as an array of events.

If it is only intended for Payment Event History Response as commented in code, SDK should define a PaymentEvent object and EPaymentPaymentEventOKResponse should have an array of this object.

TL:DR; Missing PaymentEvent object

Expected behavior

Based on this documentation: https://developer.vippsmobilepay.com/docs/APIs/epayment-api/features/webhooks/

As a developer I expect to receive an object representing an event on my endpoint.
EPaymentPaymentEventOkResponse is wrongfully typed or SDK is missing an object for webhook events.

@tomas-zijdemans-vipps
Copy link
Collaborator

tomas-zijdemans-vipps commented Jan 15, 2024

Thanks for catching this @melanki! I've submitted a PR here that also fixes a few typos and improves the handling of Scope: #27

@tomas-zijdemans-vipps
Copy link
Collaborator

I will look into the Webhook event shortly

@tomas-zijdemans-vipps
Copy link
Collaborator

@melanki : I updated the PR to add the missing Webhook type (for both ePayment and Qr). Will release a new version once it has been approved.

@tomas-zijdemans-vipps tomas-zijdemans-vipps self-assigned this Jan 15, 2024
tomas-zijdemans-vipps added a commit that referenced this issue Jan 15, 2024
* Fix epayment types to address: #23

* Add missing Webhook event types
@tomas-zijdemans-vipps
Copy link
Collaborator

Fixed in 0.7.0

@melanki
Copy link
Author

melanki commented Jan 15, 2024

Thank you for the quick response, will verify it later today.

EDIT: Fix verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants