Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface's --scripts option doesn't seem to work #1460

Closed
daleglass opened this issue Nov 21, 2021 · 7 comments
Closed

Interface's --scripts option doesn't seem to work #1460

daleglass opened this issue Nov 21, 2021 · 7 comments
Labels
bug Something isn't working dev-client-specific Severity: Low No important functionality is affected stale Issue / PR has not had activity

Comments

@daleglass
Copy link
Contributor

The option takes a path, but never seems to pass it down to the scripting engine, so it doesn't seem to actually have an useful effect.

@Penguin-Guru
Copy link

Related to #1461

I think it would be good to consider whether there is any functionality we want this to perform that is distinct from the other script parameters. If not, we could simply remove this. The name is nice and short but it is also very ambiguous.

@JulianGro
Copy link
Contributor

Probably the same issue as #827 ?

@Penguin-Guru
Copy link

Penguin-Guru commented Nov 27, 2021

No, the code for --scripts literally doesn't seem to be fully implemented. My pull request should hopefully fix all the other issues, but nobody has confirmed that yet. If you know how --scripts is related to --concurrent-downloads, please do share. That wouldn't surprise me at this point.

@JulianGro
Copy link
Contributor

Issue #827 describes that most command line options don't work on Linux.
If --scripts isn't implemented then yeah that is a different issue.

@Penguin-Guru
Copy link

Penguin-Guru commented Nov 27, 2021

Here is an overview of what I changed (though a bit out of date now) from a user's perspective.
vircadia/vircadia-dev-docs#5

Update: nevermind, those are only the undocumented ones.

@daleglass daleglass added bug Something isn't working Severity: Low No important functionality is affected labels Nov 27, 2021
@stale
Copy link

stale bot commented May 27, 2022

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label May 27, 2022
@stale stale bot removed the stale Issue / PR has not had activity label Oct 30, 2022
@stale
Copy link

stale bot commented Apr 29, 2023

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev-client-specific Severity: Low No important functionality is affected stale Issue / PR has not had activity
Projects
None yet
Development

No branches or pull requests

4 participants